Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): fix wrong uri of head request #899

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix(client): fix wrong uri of head request #899

merged 1 commit into from
Aug 10, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Screenshot_20220810_185706

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added bug 🐛 Something isn't working client 🌈 labels Aug 10, 2022
tianweidut
tianweidut approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit ceaef20 into star-whale:main Aug 10, 2022
@jialeicui jialeicui deleted the fix-head-issue branch August 15, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweidut tianweidut tianweidut approved these changes

@anda-ren anda-ren Awaiting requested review from anda-ren

Assignees
No one assigned
Labels
bug 🐛 Something isn't working client 🌈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jialeicui @tianweidut