Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dataset): remove dataset batch_size argument #910

Merged
merged 3 commits into from
Aug 15, 2022
Merged

chore(dataset): remove dataset batch_size argument #910

merged 3 commits into from
Aug 15, 2022

Conversation

tianweidut
Copy link
Member

Description

  • remove the confused batch_size argument in the dataset

Modules

  • Client
  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3 milestone Aug 15, 2022
@tianweidut tianweidut self-assigned this Aug 15, 2022
@tianweidut tianweidut changed the title chore(dataset): remove dataset batch chore(dataset): remove dataset batch_size argument Aug 15, 2022
@jialeicui
Copy link
Contributor

LGTM

@jialeicui jialeicui merged commit 6d8ad9e into star-whale:main Aug 15, 2022
@tianweidut tianweidut deleted the chore/remove-dataset-batch branch April 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jialeicui jialeicui jialeicui approved these changes

@goldenxinxing goldenxinxing Awaiting requested review from goldenxinxing

@anda-ren anda-ren Awaiting requested review from anda-ren

Assignees

@tianweidut tianweidut

Labels
client 🌈 dataset🐫
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tianweidut @jialeicui