Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): eval cmd bug #949

Merged
merged 5 commits into from
Aug 22, 2022
Merged

fix(model): eval cmd bug #949

merged 5 commits into from
Aug 22, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Aug 22, 2022 •
edited
Loading

Description

  1. step task split by dataset rows
  2. fast fail when occurring an error in the scheduling process
  3. prepare log and status dir within the pipelineHandler

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing marked this pull request as ready for review August 22, 2022 08:52
tianweidut
tianweidut requested changes Aug 22, 2022
View reviewed changes
client/starwhale/api/_impl/model.py Outdated Show resolved Hide resolved
client/starwhale/api/_impl/model.py Outdated Show resolved Hide resolved
@goldenxinxing goldenxinxing self-assigned this Aug 22, 2022
@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Aug 22, 2022
tianweidut
tianweidut approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit e284eca into star-whale:main Aug 22, 2022
@goldenxinxing goldenxinxing deleted the fix/eval_cmd_bug branch August 25, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweidut tianweidut tianweidut approved these changes

Assignees

@goldenxinxing goldenxinxing

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldenxinxing @tianweidut