Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic issue in SalaryGovPlugin #104

Closed
pause125 opened this issue Aug 31, 2022 · 2 comments · Fixed by #115
Closed

Logic issue in SalaryGovPlugin #104

pause125 opened this issue Aug 31, 2022 · 2 comments · Fixed by #115
Labels
enhancement New feature or request

Comments

@pause125
Copy link
Collaborator

Feature Request

Describe the Feature Request

For now, signer with boss_cap can set_salary_period without limit, that's in fact a way to modify the salary for all member. It's not reasonable and fair for members.

Describe Preferred Solution

Give every member an independent period config
the period can be:

  • option 1: unmodifiable
  • option 2: modified when both boss and member confirmed.

If the feature request is approved, would you be willing to submit a PR?
Yes / No (Help can be provided if you need assistance submitting a PR)

@pause125 pause125 added the enhancement New feature or request label Aug 31, 2022
@pause125
Copy link
Collaborator Author

pause125 commented Sep 3, 2022

I'm trying to fix this and add integration test, but found a more serious issue, that is: every member's SBT amount is 0, and there's no boss in the initial state, and the boss can only be selected through proposal but no one has vote weights. It's deadlock!

So I want to know which scenario will this plugin be used for and try to find a feasible solution. @jolestar @WGB5445 @baichuan3 @welbon

@jolestar
Copy link
Member

jolestar commented Sep 4, 2022

I think the salary and boss system are too complex to adapt to different DAO, and we should move the SalaryGovPlugin as a test plugin;

maybe it can be a third-party plugin not in Framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants