Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: DAOSpace Use Offer for Member and Grant #125

Closed
jolestar opened this issue Sep 16, 2022 · 6 comments
Closed

[Feature Request]: DAOSpace Use Offer for Member and Grant #125

jolestar opened this issue Sep 16, 2022 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@jolestar
Copy link
Member

Feature Request

Describe the Feature Request

当前如果要邀请用户加入 DAO,投票通过后,用户无法直接加入,该用户必须先 Accept 成员 NFT, 然后才能加入。给用户发 Grant 也有类似的问题。

是否考虑提供 Offer 机制,先将 NFT 或者 Grant 放在 Offer 里,存在 DAO 账户下,然后用户自己来领取?不过这个也涉及 Offer module 的重构,需要将 Offer 改造成数组,这样才能保存多个。

Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
Yes / No (Help can be provided if you need assistance submitting a PR)

@jolestar jolestar added the enhancement New feature or request label Sep 16, 2022
@jolestar jolestar added this to the v12 milestone Sep 16, 2022
@jolestar
Copy link
Member Author

@WGB5445 @0xpause

@pause125
Copy link
Collaborator

从 Offer 里取是不是也要用户先 Accept 操作?

@jolestar
Copy link
Member Author

从 Offer 里取是不是也要用户先 Accept 操作?

Offer 是保存在 DAO 账户下的,用户来取的时候就顺便 accept 了,不需要预先 accept。

@WGB5445
Copy link
Collaborator

WGB5445 commented Sep 18, 2022

这个我来搞吧,增加一个 offer_v2

@jolestar
Copy link
Member Author

这个我来搞吧,增加一个 offer_v2

或者弄成自动化的,如果只有一个 offer 就直接存,存第二个的时候变成数组。

@WGB5445 WGB5445 mentioned this issue Sep 19, 2022
7 tasks
@pause125
Copy link
Collaborator

#174 已经解决,关闭该 issue。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants