[Code]: DAOSpace GlobalProposals not removed after being executed or rejected.

[pause125]

GlobalProposals is never removed after being executed or rejected.

The vector is always growing, there may have state explosion issue.

[jolestar]

also, need to add max limit to GlobalProposals

starcoin-framework/sources/daospace/DAOSpace.move

Lines 1467 to 1470 in e82c1d3

	if(exists<GlobalProposalActions>(dao_address)){
	//TODO add limit to max global proposal action indexs before support Table
	let current_global_proposal_actions = borrow_global_mut<GlobalProposalActions>(dao_address);
	Vector::append(&mut current_global_proposal_actions.proposal_action_indexs, proposal_action_indexs);

[pause125]

Delete proposal after executed or rejected directly? Is there a need to keep them for querying history proposal info?

[jolestar]

Delete proposal after executed or rejected directly. Is there a need to keep them for querying history proposal info?

I think they can bean deleted. The history proposal can query from history state or off-chain index DB.

[pause125]

ok, I will fix it.