Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor]: Try to use Global Registry for Token and deprecated native method name_of #18

Closed
jolestar opened this issue Mar 21, 2022 · 1 comment
Closed

[Refactor]: Try to use Global Registry for Token and deprecated native method name_of #18

jolestar opened this issue Mar 21, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jolestar
Copy link
Member

  1. Global Registry can eliminate the requirement of name_of.
  2. The only issue that needs to be resolved is dependency. But the Token Global Registry is dependent on the GenesisSignerCapability, the GenesisSignerCapability is dependent on the Account, and the Account is dependent on the Token.
  3. The possible way is to move the Account::create_signer function to a new Module and marks it as friend.
@jolestar jolestar added the enhancement New feature or request label Mar 21, 2022
@jolestar jolestar mentioned this issue Aug 3, 2022
Merged
7 tasks
@jolestar
Copy link
Member Author

jolestar commented Sep 16, 2022 •
edited
Loading

We decide to keep name_of and public it as TypeInfo. #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jolestar