Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code]: If a sender can create more than one DAOAccountCap ? #88

Closed
pause125 opened this issue Aug 15, 2022 · 2 comments
Closed

[Code]: If a sender can create more than one DAOAccountCap ? #88

pause125 opened this issue Aug 15, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@pause125
Copy link
Collaborator

From a design perspective, is it allowed to create multiple DAOAccountCaps for one account? In the code, there seems to be no mechanism to restrict a single account from creating multiple DAOAccountCaps. But in the code, here and here don't check if the sender has a DAOAccountCap resource. They are missed or just no need to check ?

@pause125 pause125 added the enhancement New feature or request label Aug 15, 2022
@jolestar
Copy link
Member

  1. Should check the DAOAccountCap exists before move_to
  2. If a user creates DAOAccount and then delegates the DAOAccountCap to DAO, then he can create another DAOAccount.

@pause125
Copy link
Collaborator Author

Already checked in #89 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants