Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] replace starcoin-cmd dev::tests::test_upgrade_module with integration-test #3733

Closed
jiangying000 opened this issue Sep 13, 2022 · 0 comments · Fixed by #3741
Closed
Labels
enhancement Enhancement help wanted Extra attention is needed test

Comments

@jiangying000
Copy link
Collaborator

reasons:

  1. this test is prone to failure in unit tests, see https://github.com/starcoinorg/starcoin/actions/runs/3043351262/jobs/4902518532#step:10:15340
  2. there is a comment: //TODO replace this with integration-test
    //TODO replace this with integration-test
    #[stest::test(timeout = 300)]
    fn test_upgrade_module() {
    let mut node_config = NodeConfig::random_for_test();
    node_config.miner.disable_mint_empty_block = Some(true);
    let config = Arc::new(node_config);
    let node_handle = run_node_by_config(config.clone()).unwrap();
    let rpc_service = node_handle.rpc_service().unwrap();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement help wanted Extra attention is needed test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant