Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change EmbeddingProvider from interface to abstract class #1173

Closed
Hazel-Datastax opened this issue Jun 17, 2024 · 1 comment
Closed

Change EmbeddingProvider from interface to abstract class #1173

Hazel-Datastax opened this issue Jun 17, 2024 · 1 comment
Assignees
@Hazel-Datastax

Comments

@Hazel-Datastax
Copy link
Contributor

It's from Tatu's comment in #1159
@Hazel-Datastax Hazel-Datastax mentioned this issue Jun 17, 2024
Merged
4 tasks
@tatu-at-datastax
Copy link
Contributor

And specifically this is done to allow adding configuration state, shared functionality (interfaces can only have public methods, and no fields)

@Hazel-Datastax Hazel-Datastax self-assigned this Jun 18, 2024
@Hazel-Datastax Hazel-Datastax mentioned this issue Jun 24, 2024
Merged
4 tasks
@sync-by-unito sync-by-unito bot closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hazel-Datastax Hazel-Datastax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tatu-at-datastax @Hazel-Datastax