Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table read option to include null values #1636

Open
Yuqi-Du opened this issue Nov 1, 2024 · 2 comments
Open

Table read option to include null values #1636

Yuqi-Du opened this issue Nov 1, 2024 · 2 comments
Labels
Feature - Tables Issue impacts the users of Tables Feature Agreed feature yet to be implemented To-Do

Comments

@Yuqi-Du
Copy link
Contributor

Yuqi-Du commented Nov 1, 2024

For table read, we made the decision of not returning null column values.
So we need to have an option of let user override the default behavior.

This nullOption is originally included in #1633, @amorton wants to think on naming stuff, so separate out as an issue,

related issue
#1571

@amorton amorton added the Feature Agreed feature yet to be implemented label Nov 6, 2024
@amorton amorton changed the title Table read path nullOption Table read option to include null values Nov 6, 2024
@amorton amorton added the On Hold Not ready for active development label Nov 6, 2024
@amorton
Copy link
Contributor

amorton commented Dec 11, 2024

lets call the option enableVerboseData , the problem is this will be default to false for tables or true for collections. Does not matter what the flag is called, it will be diff for the two :(

the other choice we had was disableSparseData.

Lets get the feature ready and then see what the command looks like, the hard part will be how we make this make sense for tables and collections.

@amorton amorton added Feature - Tables Issue impacts the users of Tables To-Do and removed On Hold Not ready for active development labels Dec 11, 2024
@amorton
Copy link
Contributor

amorton commented Dec 11, 2024

discussion - go with enableVerboseData as the name, defaults to false, and if set to true and it is a Collection throw an error. For collections we assume the user put NULLS into the document on purpose. Can revisit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature - Tables Issue impacts the users of Tables Feature Agreed feature yet to be implemented To-Do
Projects
None yet
Development

No branches or pull requests

2 participants