From 221d12626a8a106a3283dcac07a36deec8eec36c Mon Sep 17 00:00:00 2001
From: Jeffrey Carpenter <jeffrey.carpenter@datastax.com>
Date: Sat, 23 Sep 2023 08:51:47 -0700
Subject: [PATCH] ensure password is masked on ecr login

---
 .github/workflows/continuous-integration.yaml | 2 ++
 .github/workflows/docker-image-publish.yaml   | 4 ++++
 .github/workflows/performance-testing.yaml    | 2 ++
 .github/workflows/postman-docker.yaml         | 2 ++
 .github/workflows/release.yaml                | 4 ++++
 5 files changed, 14 insertions(+)

diff --git a/.github/workflows/continuous-integration.yaml b/.github/workflows/continuous-integration.yaml
index 7c33d905f2..eddfc2562f 100644
--- a/.github/workflows/continuous-integration.yaml
+++ b/.github/workflows/continuous-integration.yaml
@@ -102,6 +102,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       # run the int tests
       - name: Integration Test
diff --git a/.github/workflows/docker-image-publish.yaml b/.github/workflows/docker-image-publish.yaml
index 119cbaafd6..901709b202 100644
--- a/.github/workflows/docker-image-publish.yaml
+++ b/.github/workflows/docker-image-publish.yaml
@@ -61,6 +61,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       - name: Build and push (Amazon ECR)
         run: |
@@ -97,6 +99,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       - name: Sign a docker image
         shell: bash
diff --git a/.github/workflows/performance-testing.yaml b/.github/workflows/performance-testing.yaml
index f0cfbc3660..7669b81efb 100644
--- a/.github/workflows/performance-testing.yaml
+++ b/.github/workflows/performance-testing.yaml
@@ -85,6 +85,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       # Use docker-compose to start required stack
       # Pull JSON API image from ECR corresponding to latest commit on main branch
diff --git a/.github/workflows/postman-docker.yaml b/.github/workflows/postman-docker.yaml
index a62e542d59..bb128148f1 100644
--- a/.github/workflows/postman-docker.yaml
+++ b/.github/workflows/postman-docker.yaml
@@ -42,6 +42,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
         # Run Stargate coordinator in developer mode to save time / resources
         # Pull JSON API image from ECR corresponding to latest commit on main branch
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index edea1067b4..2ec03e6ba2 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -130,6 +130,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       # downloads and prepares datastax assets
       - name: Download branding assets
@@ -186,6 +188,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       - name: Sign a docker image
         shell: bash