Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize case of "no projection" (include all) so that doc_json embedded directly #667

Closed
tatu-at-datastax opened this issue Nov 21, 2023 · 2 comments
Assignees

Comments

@tatu-at-datastax
Copy link
Contributor

One possible optimization we may be able to do is to short-circuit "parse-JSON from doc_json, modify, write as JSON" for the special case of no/empty Projection: this is where we may be able to simply inject contents of doc_json into output and avoid at least serialization, but possibly also deserialization cost.

@tatu-at-datastax tatu-at-datastax self-assigned this Nov 21, 2023
@tatu-at-datastax
Copy link
Contributor Author

After studying the code I am not sure this is feasible to do: document is carried along as JsonNode-based representation which is mutable, and the original String containing doc_json is not passed, nor is it clear how to keep track of changes to Document object (to know if it might have been changed).

Will keep open for a bit in case I get an idea of how to work around challenges.

@tatu-at-datastax
Copy link
Contributor Author

I don't think this is feasible as things are; closing.

@tatu-at-datastax tatu-at-datastax closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant