Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change terminology from "database" to "namespace" #101

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Change terminology from "database" to "namespace" #101

merged 3 commits into from
Feb 13, 2023

Conversation

jeffreyscarpenter
Copy link
Contributor

As we've done in the specification, update the JSON API code to have a "namespace" resource instead of "database" to prevent confusion with other usage of the term "database".

Fixes #93

@jeffreyscarpenter jeffreyscarpenter requested a review from a team as a code owner February 12, 2023 20:52
ivansenic
ivansenic suggested changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@ivansenic ivansenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed command renaming and more importantly the command json type name which dictates the JSON look. Also doing find in files shows like 100+ files where database is still defined and use somehow:

image

src/main/java/io/stargate/sgv2/jsonapi/api/model/command/impl/CreateDatabaseCommand.java Outdated Show resolved Hide resolved
...main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/CreateDatabaseOperation.java Outdated Show resolved Hide resolved
.../java/io/stargate/sgv2/jsonapi/service/resolver/model/impl/DeleteOneCommandResolverTest.java Show resolved Hide resolved
ivansenic
ivansenic approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@ivansenic ivansenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good..

@jeffreyscarpenter jeffreyscarpenter merged commit e81bbc6 into main Feb 13, 2023
@jeffreyscarpenter jeffreyscarpenter deleted the jeff/namespace-resource branch February 13, 2023 17:46
vkarpov15
vkarpov15 reviewed Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 left review comments

@ivansenic ivansenic ivansenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename database to namespace
3 participants
@jeffreyscarpenter @vkarpov15 @ivansenic