Support dot-notation with $inc update operator #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,8 @@ public static PopOperation construct(ObjectNode args) { | |||
| List<PopAction> actions = new ArrayList<>(); | |||
| while (fieldIter.hasNext()) { | |||
| Map.Entry<String, JsonNode> entry = fieldIter.next(); | |||
| final String name = entry.getKey(); | |||
| final String path = validateUpdatePath(UpdateOperator.POP, entry.getKey()); | |||
There was a problem hiding this comment.
Was missing verification we won't target _id -- would fail anyway as _id cannot be an Array, but Mongo catches immutability problem before structural difference.
| */ | ||
| protected static String validateSetPath(UpdateOperator oper, String path) { | ||
| protected static String validateUpdatePath(UpdateOperator oper, String path) { |
There was a problem hiding this comment.
Renamed since now used by all update operators.
tatu-at-datastax
changed the title
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Supports dot-notation (nested paths) for
$incoperator (currently only works on root-level properties).Which issue(s) this PR fixes:
Fixes #183
Checklist