Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update - LWT transaction failure retries #231

Merged
merged 7 commits into from
Mar 8, 2023
Merged

Update - LWT transaction failure retries #231

merged 7 commits into from
Mar 8, 2023

Conversation

maheshrajamani
Copy link
Contributor

@maheshrajamani maheshrajamani commented Mar 8, 2023 •
edited
Loading

What this PR does:
Update - LWT transaction failure retries

Which issue(s) this PR fixes:
Fixes #228

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@maheshrajamani maheshrajamani marked this pull request as ready for review March 8, 2023 18:10
@maheshrajamani maheshrajamani requested a review from a team as a code owner March 8, 2023 18:10
tatu-at-datastax
tatu-at-datastax approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks Good To Me. Not sure I can validate actual retry logic, but I think Ivan was offering his suggestions earlier and so that should be good to go.

@maheshrajamani
Copy link
Contributor Author

maheshrajamani commented Mar 8, 2023 •
edited
Loading

Not sure I can validate actual retry logic, but I think Ivan was offering his suggestions earlier and so that should be good to go.

Added an IT LwtRetryIntegrationTest which will run as @execution(ExecutionMode.CONCURRENT).
The test method is repeated 3 times (retry limit is 3) and checked for no errors everytime.

@maheshrajamani maheshrajamani merged commit f504fc6 into main Mar 8, 2023
@maheshrajamani maheshrajamani deleted the update-lwt-retry branch March 8, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update - LWT transaction failure retries
2 participants
@maheshrajamani @tatu-at-datastax