Add $rename update operator
#271
Conversation
tatu-at-datastax
changed the title
$rename update operator$rename update operator
src/main/java/io/stargate/sgv2/jsonapi/api/configuration/ObjectMapperConfiguration.java
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/api/model/command/clause/update/RenameOperation.java
Outdated
Show resolved
Hide resolved
| // If there is a value will be a modification (since source value will | ||
| // disappear), regardless of whether target changes | ||
| modified = true; | ||
| PathMatch dst = action.targetLocator().findOrCreate(doc); |
There was a problem hiding this comment.
There is document which has address sub-document like {"address" : {"address line" : "123 main st", "city" : "NYC", "state": "NY"}}
If the update request is to rename city to town, the sub-document fields (city and state) order will change as {"address" : {"address line" : "123 main st", "state": "NY", "city" : "NYC"}}? Is this the expected behavior?
There was a problem hiding this comment.
@maheshrajamani As far as I can see, mongo docs state (and Atlas seem to implement it like so) that $rename is implemented as "$unset followed by $set"; and $set appends at the end.
So I think it would indeed be expected that field "moves" the way you describe; city removed, town appended.
|
One thing I may want to do is to check the case of 'src == dst` -- looks like that needs to become an error too. EDIT: done. |
What this PR does:
Adds
$renamegeneral update operatorWhich issue(s) this PR fixes:
Fixes #165
Checklist