Refactor FilterableResolver to address #201 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the command needed a read to resolve the document. Addresses concern in #201
maheshrajamani
commented
Mar 22, 2023
| KEY, | ||
| /** Return only count of documents which satisfies the filter condition */ | ||
| COUNT | ||
| KEY |
There was a problem hiding this comment.
Holding on to this Enum, will be adding SORT_DOCUMENT type in the next PR for in memory sort.
maheshrajamani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Refactored FilterableResolver to resolve to DBFilters.
Change the update and delete method to use FindOperation instead of ReadOperation
Removed getDocuments and getNewDocument from ReadOperation interface.
Refactored the test cases
Which issue(s) this PR fixes:
Fixes #201
Checklist