closes #298: count down latch to be decrease on assertion errors #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivansenic
force-pushed
the
ise-298-cdl-fix
branch
from
62d596a to
93a3d21
Compare
maheshrajamani
approved these changes
Mar 27, 2023
src/main/java/io/stargate/sgv2/jsonapi/service/bridge/executor/QueryExecutor.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 28, 2023 11:37
ivansenic
force-pushed
the
ise-298-cdl-fix
branch
from
93a3d21 to
5b680f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes the count down latch now being decreased on failed asserts.. This will never result in a block..
But the exception would be ignored.. Thus I am thinking what the options are:
AtomicReference, after CTL goes to zero iterate over and re-throw any exception?Which issue(s) this PR fixes:
Fixes #298
WARNING: remove serial consistency commit before merging