Generate and add _id field in Doc if not passed #32
Conversation
| String id = null; | ||
| // We will extract id if there is one; stored separately, but also included in JSON document | ||
| // before storing in persistence. Need to make copy to avoid modifying input doc | ||
| ObjectNode docWithoutId = ((ObjectNode) doc).objectNode().setAll((ObjectNode) doc); |
There was a problem hiding this comment.
Why do we need to remove id and add it back again to new document? Can just do docOb.get("_id") and later do docOb.put("_id", id)? So don't need to create new ObjectNode (docWithoutId and docWithId)
There was a problem hiding this comment.
Ah. Forgot to add a note on that: while not mandatory, was thinking that we want to order things so that _id is always the first property. Just a preference, but I think this is what happens with Mongo.
But there is also the additional complexity in traversal: code later on assumes that _id is not passed so there won't be index fields for it. So if it was not removed, more checks would be needed not to expose _id via callbacks.
There was a problem hiding this comment.
Added note: underlying ObjectNode uses LinkedHashMap to preserve ordering. While this is bit of an implementation detail it is very unlikely to change for Jackson (esp. 2.x) since changing that would be major compatibility change in practice.
| * <p>This will be based on the ideas in the python lab, and extended to do things like make better | ||
| * decisions about when to use a hash and when to use the actual value. i.e. a hash of "a" is a lot | ||
| * longer than "a". | ||
| * <p>Implementation is based on the ideas in the python lab, and extended to do things like make |
There was a problem hiding this comment.
Should the production code make reference to the python lab?
There was a problem hiding this comment.
Probably not. I think I will change it to more generic language but retaining otherwise as-is, for now.
Fixes: #28,
_idwill be generated (using UUID.random()) if needed, will be included indocJsonregardless of source.