Implementation for findOneAndReplace command #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheshrajamani
commented
Mar 30, 2023
| import java.util.List; | ||
|
|
||
| /** Updates the document read from the database with the updates came as part of the request. */ | ||
| public record DocumentUpdater(List<UpdateOperation> updateOperations) { | ||
| public record DocumentUpdater( |
There was a problem hiding this comment.
@tatu-at-datastax I believe extending DocumentUpdater for replace, hope this fine.
There was a problem hiding this comment.
Yes, makes sense wrt functionality. If we need more types in future may want to refactor.
I'll add one idea down below however.
| @@ -14,6 +14,9 @@ public enum ErrorCode { | |||
|
|
|||
| DOCUMENT_UNPARSEABLE("Unable to parse the document"), | |||
|
|
|||
| DOCUMENT_REPLACE_DIFFERENT_DOCID( | |||
| "The replace document and document resolved using filter has different _id"), | |||
| JsonNode idNode = compareDoc.remove(DocumentConstants.Fields.DOC_ID); | ||
| // The replace document cannot specify an _id value that differs from the replaced document. | ||
| if (replaceDocumentId != null) { | ||
| if (JsonNodeComparator.ascending().compare(replaceDocumentId, idNode) != 0) { |
There was a problem hiding this comment.
Simple equality check works for kinds of JsonNodes that are legal as doc-ids, so no need for comparator.
But maybe better is to use existing method from JsonUtil; equalsOrdered()? That would work even if allowed more types and is designed for equality checks.
There was a problem hiding this comment.
OK. Will use JsonUtil
| @@ -299,4 +299,132 @@ public void invalidSetOnParentPathWithDollar() { | |||
| "Update operator path conflict due to overlap: 'root' ($set) vs 'root.a' ($set)"); | |||
| } | |||
| } | |||
|
|
|||
| @Nested | |||
| class ReplaceDocuemntHappy { | |||
There was a problem hiding this comment.
nit: Docuemnt -> Document
Review comment changes
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implementation for findOneAndReplace command
Which issue(s) this PR fixes:
Fixes #311
Checklist