FindOneAndDelete command implementation #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheshrajamani
changed the title
maheshrajamani
changed the title
| @@ -138,7 +172,7 @@ private QueryOuterClass.Query buildDeleteQuery() { | |||
| * @return Uni<Boolean> `true` if deleted successfully, else `false` if data changed and no longer | |||
There was a problem hiding this comment.
Changed to Tuple2, need to update javadoc
| return FindOperation.sorted( | ||
| commandContext, | ||
| filters, | ||
| // 24-Mar-2023, tatu: Since we update the document, need to avoid modifications on |
There was a problem hiding this comment.
Can remove these comments where copying old tests (for all test setup same applies)
tatu-at-datastax
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implement findOneAndDelete command which finds and deletes a document and returns the deleted document in the response
Which issue(s) this PR fixes:
Fixes #319
Checklist