Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added upsert support for findOneAndReplace #345

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Added upsert support for findOneAndReplace #345

merged 3 commits into from
Apr 12, 2023

Conversation

maheshrajamani
Copy link
Contributor

@maheshrajamani maheshrajamani commented Apr 11, 2023 •
edited
Loading

What this PR does:
Added upsert support for findOneAndReplace
Which issue(s) this PR fixes:
Fixes #311 and #324 comment

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@maheshrajamani maheshrajamani marked this pull request as ready for review April 12, 2023 13:39
@maheshrajamani maheshrajamani requested a review from a team as a code owner April 12, 2023 13:39
tatu-at-datastax
tatu-at-datastax approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very straightforward.

@maheshrajamani maheshrajamani merged commit 00dd280 into main Apr 12, 2023
@maheshrajamani maheshrajamani deleted the upsert-find-and-replace branch April 12, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 left review comments

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement findOneAndReplace command
3 participants
@maheshrajamani @vkarpov15 @tatu-at-datastax