DeleteOne command #29 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delete # Conflicts: # src/test/java/io/stargate/sgv3/docsapi/api/v3/CollectionResourceIntegrationTest.java
ivansenic
suggested changes
Jan 18, 2023
src/main/java/io/stargate/sgv3/docsapi/api/model/command/impl/DeleteOneCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv3/docsapi/service/operation/model/impl/DeleteOperation.java
Show resolved
Hide resolved
src/main/java/io/stargate/sgv3/docsapi/service/operation/model/impl/DeleteOperation.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv3/docsapi/service/operation/model/impl/DeleteOperation.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv3/docsapi/service/operation/model/impl/FindOperation.java
Outdated
Show resolved
Hide resolved
...main/java/io/stargate/sgv3/docsapi/service/resolver/model/impl/DeleteOneCommandResolver.java
Outdated
Show resolved
Hide resolved
src/test/java/io/stargate/sgv3/docsapi/api/v3/CollectionResourceIntegrationTestBase.java
Outdated
Show resolved
Hide resolved
src/test/java/io/stargate/sgv3/docsapi/api/v3/DeleteOneIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/stargate/sgv3/docsapi/api/v3/DeleteOneIntegrationTest.java
Outdated
Show resolved
Hide resolved
Json is updated with value making sense Made the FilterResolver not implement CommandResolver so it can return ReadOperation instead of Operation For a document in the database the transaction id will always be not null, so removing the Optional.
ivansenic
reviewed
Jan 18, 2023
… in object mapper
ivansenic
suggested changes
Jan 19, 2023
There was a problem hiding this comment.
One more iteration and we are done.. Some general issues below..
- Warning about pom issues:
{[INFO] Scanning for projects... [WARNING] [WARNING] Some problems were encountered while building the effective model for io.stargate:sgv3-docsapi:jar:3.0.0-SNAPSHOT [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.mockito:mockito-junit-jupiter:jar -> duplicate declaration of version (?) @ line 105, column 17 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/FilterClause.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv3/docsapi/service/operation/model/impl/DeleteOperation.java
Show resolved
Hide resolved
src/main/java/io/stargate/sgv3/docsapi/service/operation/model/impl/FindOperation.java
Show resolved
Hide resolved
src/main/java/io/stargate/sgv3/docsapi/service/resolver/model/impl/FindOneCommandResolver.java
Show resolved
Hide resolved
...main/java/io/stargate/sgv3/docsapi/service/resolver/model/impl/DeleteOneCommandResolver.java
Outdated
Show resolved
Hide resolved
.../java/io/stargate/sgv3/docsapi/service/resolver/model/impl/DeleteOneCommandResolverTest.java
Outdated
Show resolved
Hide resolved
...st/java/io/stargate/sgv3/docsapi/service/resolver/model/impl/FindOneCommandResolverTest.java
Show resolved
Hide resolved
...in/java/io/stargate/sgv3/docsapi/service/resolver/model/impl/matcher/FilterableResolver.java
Outdated
Show resolved
Hide resolved
.../java/io/stargate/sgv3/docsapi/service/resolver/model/impl/matcher/FilterMatchRulesTest.java
Show resolved
Hide resolved
ivansenic
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.