NoSQLBench workloads - auto token generation #358
Conversation
|
This has been tested with locally compiled version of nb5, but should not be merged until the release of NB 5.17.3. |
Actually this is not correct. Tests pass with NB 5.17.2, and this can be approved and merged. https://github.com/stargate/jsonapi/actions/runs/4708744043 |
|
|
||
| # nb5 -v run driver=http yaml=http-jsonapi-crud-basic jsonapi_host=my_jsonapi_host auth_token=$AUTH_TOKEN | ||
|
|
||
| description: | | ||
| description: >2 |
There was a problem hiding this comment.
is this change wanted? what s >2 doing?
There was a problem hiding this comment.
this is a convention that Jeff Banks added to the equivalent Docs API tests in the main nosqlbench repo. I think it means that what follows is structured data with 2 space indentation.
There was a problem hiding this comment.
I think that's a YAML feature, where there's a myriad of ways to specify how text blocks are included (String values, not YAML markup -- often embedded JSON, XML, CSV, shell scripts)
Which can be convenient but also confusing until you learn all of them when someone uses them (at least I find them confusing).
|
|
||
| # spread into different spaces to use multiple connections | ||
| space: HashRange(1,<<connections:20>>); ToString(); | ||
|
|
||
| # http request id | ||
| request_id: ToHashedUUID(); ToString(); | ||
| token: Discard(); Token('<<auth_token:>>','<<uri:http://localhost:8081/v1/auth>>', '<<uid:cassandra>>', '<<pswd:cassandra>>'); |
There was a problem hiding this comment.
will this do an auth request on each cycle?
There was a problem hiding this comment.
no, NB caches the token
There was a problem hiding this comment.
Good. but can you add a small comment here, explaining what the parameters are.. I guess first parameter is token given from the command line and if given, don't call the auth api? In addition it's good to know that the result of the token is saved in the {{token}} var.
There was a problem hiding this comment.
added comment
Good catch, thanks. I have pushed a fix so you can re-review. |
| @@ -21,13 +21,14 @@ bindings: | |||
| # single host: jsonapi_host=host1 | |||
| # multiple hosts: jsonapi_host=host1,host2,host3 | |||
| # multiple weighted hosts: jsonapi_host=host1:3,host2:7 | |||
| weighted_hosts: WeightedStrings('<<jsonapi_host:jsonapi>>') | |||
| weighted_hosts: WeightedStrings('<<jsonapi_host:stargate>>') | |||
There was a problem hiding this comment.
I am still like why don't we have localhost as default? In addition, this change is also only available in this file, not the others.
There was a problem hiding this comment.
I'm going to revert this change for consistency
|
|
||
| # spread into different spaces to use multiple connections | ||
| space: HashRange(1,<<connections:20>>); ToString(); | ||
|
|
||
| # http request id | ||
| request_id: ToHashedUUID(); ToString(); | ||
| token: Discard(); Token('<<auth_token:>>','<<uri:http://localhost:8081/v1/auth>>', '<<uid:cassandra>>', '<<pswd:cassandra>>'); |
There was a problem hiding this comment.
Good. but can you add a small comment here, explaining what the parameters are.. I guess first parameter is token given from the command line and if given, don't call the auth api? In addition it's good to know that the result of the token is saved in the {{token}} var.
|
FYI @maheshrajamani - I made a couple additional small improvements to address feedback from @ivansenic re-review. |
Update JSON API NoSQLBench workloads to take advantage of automatic token generation.
Also includes minor changes to emulate improvements made to Docs API NB workloads under nosqlbench/nosqlbench#1201
Checklist