Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional test wrt #329 as per code review suggestion #364

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Additional test wrt #329 as per code review suggestion #364

merged 2 commits into from
Apr 18, 2023

Conversation

tatu-at-datastax
Copy link
Contributor

What this PR does:

Adds one more IT wrt #329 for $slice on nested array

Which issue(s) this PR fixes:
N/A

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax self-assigned this Apr 17, 2023
@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner April 17, 2023 21:03
@tatu-at-datastax tatu-at-datastax mentioned this pull request Apr 17, 2023
Merged
4 tasks
@tatu-at-datastax tatu-at-datastax merged commit 70dc5e3 into main Apr 18, 2023
@tatu-at-datastax tatu-at-datastax deleted the tatu/329-add-nested-array-test branch April 18, 2023 00:03
vkarpov15
vkarpov15 reviewed Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 left review comments

@maheshrajamani maheshrajamani maheshrajamani approved these changes

Assignees

@tatu-at-datastax tatu-at-datastax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tatu-at-datastax @vkarpov15 @maheshrajamani