Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for insert many #38

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Changes for insert many #38

merged 4 commits into from
Jan 24, 2023

Conversation

maheshrajamani
Copy link
Contributor

Insert many changes

@maheshrajamani
Changes for insert many
18203eb 
# Conflicts:
#	src/main/java/io/stargate/sgv3/docsapi/api/model/command/Command.java
#	src/main/java/io/stargate/sgv3/docsapi/api/v3/CollectionResource.java
@maheshrajamani
Change the test case as insertMany
6c52009
@maheshrajamani
Fix for IT for insert many
bf6b856
tatu-at-datastax
tatu-at-datastax approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good: added some future suggestions but I think it is more important to get this merged in as-is for now since it's been converted to new style in this repo.

@maheshrajamani maheshrajamani merged commit 127713b into main Jan 24, 2023
@maheshrajamani maheshrajamani deleted the insert-many branch January 24, 2023 00:44
maheshrajamani added a commit that referenced this pull request Jan 24, 2023
@maheshrajamani
Changes for insert many (#38)
3137b3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maheshrajamani @tatu-at-datastax