findOneAndUpdate() and findOneAndReplace() to return document when no data change
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheshrajamani
changed the title
findOneAndUpdate() return document when no data changefindOneAndUpdate() and findOneAndReplace() to return document when no data change
| @@ -176,7 +175,7 @@ public void byIdWithIdNoChange() { | |||
| .post(CollectionResource.BASE_PATH, namespaceName, collectionName) | |||
| .then() | |||
| .statusCode(200) | |||
| .body("data.docs", hasSize(0)) | |||
There was a problem hiding this comment.
Could maybe change to check hasSize(1) (to prevent accepting returning multiple documents)
| .post(CollectionResource.BASE_PATH, namespaceName, collectionName) | ||
| .then() | ||
| .statusCode(200) | ||
| .body("data.docs[0]", jsonEquals(document)) |
There was a problem hiding this comment.
Check for hasSize(1) as well?
tatu-at-datastax
approved these changes
Apr 24, 2023
vkarpov15
added a commit
to stargate/stargate-mongoose
that referenced
this pull request
Apr 25, 2023
4 tasks
kathirsvn
pushed a commit
to stargate/stargate-mongoose
that referenced
this pull request
Apr 25, 2023
* support sort with `find()` * add sort to findOne(), findOneAndUpdate(), findOneAndReplace() * quick fix for tests * add findOneAndDelete(), count() implementation * quick indent fix, skip test for stargate/data-api#392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
findOneAndUpdate()return document when no data changeWhich issue(s) this PR fixes:
Fixes #390
Checklist