Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #373: add basic tests to verify "$date" wrt Projection #393

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Fix #373: add basic tests to verify "$date" wrt Projection #393

merged 2 commits into from
Apr 25, 2023

Conversation

tatu-at-datastax
Copy link
Contributor

What this PR does:

Adds simple testing to ensure Projection works with Date valued fields

Which issue(s) this PR fixes:
Fixes #373

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner April 24, 2023 22:40
@tatu-at-datastax tatu-at-datastax self-assigned this Apr 24, 2023
maheshrajamani
maheshrajamani approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@maheshrajamani maheshrajamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a test case that excludes sub document which does the same, but can you also add a date field exclusion as separate test case.

@tatu-at-datastax
Copy link
Contributor Author

There is a test case that excludes sub document which does the same, but can you also add a date field exclusion as separate test case.

Will do.

@tatu-at-datastax tatu-at-datastax merged commit 3e0141c into main Apr 25, 2023
@tatu-at-datastax tatu-at-datastax deleted the tatu/373-test-date-with-projection branch April 25, 2023 16:01
vkarpov15
vkarpov15 reviewed Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 left review comments

@maheshrajamani maheshrajamani maheshrajamani approved these changes

Assignees

@tatu-at-datastax tatu-at-datastax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Date/Time support) Ensure Projection of Date/Time valued fields works
3 participants
@tatu-at-datastax @vkarpov15 @maheshrajamani