Fix #395: verify that "no options" Commands are not given any options #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatu-at-datastax
commented
May 2, 2023
| */ | ||
| @JsonIgnoreProperties({"options"}) | ||
| public interface NoOptionsCommand {} | ||
| @RegisterForReflection |
There was a problem hiding this comment.
Without this, Native build CI/ITs failed; adding made them pass. Not 100% sure why but suspecting that default method implementation (annotation included, in particular) would not be retained.
I am glad we have tests for that set up to catch these problems.
maheshrajamani
approved these changes
May 2, 2023
|
|
||
| // Only "empty" Options allowed, nothing else | ||
| @Test | ||
| public void illegalFilterConditionEmptyOptions() throws Exception { |
There was a problem hiding this comment.
Can this test be moved into ObjectMapperConfigurationTest.FindOne? Thats where the command is resolved.
This class is used to test resolving commands to operation.
There was a problem hiding this comment.
@maheshrajamani Ok makes sense, will move.
Yes, will add to same place where FindOneCommand unit test goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds validation for
NoOptionsCommandso that attempts to send options results in a failureWhich issue(s) this PR fixes:
Fixes #395
Checklist