Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #408: validate characters of document field names #429

Merged
merged 3 commits into from
May 16, 2023
Merged

Fix #408: validate characters of document field names #429

merged 3 commits into from
May 16, 2023

Conversation

tatu-at-datastax
Copy link
Contributor

What this PR does:

Adds simple regexp-based validation for field names of document, enforced during shredding

Which issue(s) this PR fixes:
Fixes #408

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner May 15, 2023 17:39
@tatu-at-datastax tatu-at-datastax self-assigned this May 15, 2023
@tatu-at-datastax tatu-at-datastax marked this pull request as draft May 15, 2023 18:57
@tatu-at-datastax
Copy link
Contributor Author

Hmmmh. Need to consider the fact that we do need to allow use of $date for Date datatype encoded values.

vkarpov15
vkarpov15 approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far 👍

@tatu-at-datastax tatu-at-datastax marked this pull request as ready for review May 16, 2023 02:11
@tatu-at-datastax tatu-at-datastax merged commit 6ca38e7 into main May 16, 2023
@tatu-at-datastax tatu-at-datastax deleted the tatu/408-validate-doc-key-chars branch May 16, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffreyscarpenter jeffreyscarpenter jeffreyscarpenter approved these changes

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees

@tatu-at-datastax tatu-at-datastax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate Document field names so they conform to the spec
3 participants
@tatu-at-datastax @vkarpov15 @jeffreyscarpenter