Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find command options validation and tenant based cache #487

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Find command options validation and tenant based cache #487

merged 6 commits into from
Aug 1, 2023

Conversation

maheshrajamani
Copy link
Contributor

@maheshrajamani maheshrajamani commented Aug 1, 2023 •
edited
Loading

What this PR does:

  • Validation for find command options
  • Schema cache by tenant and namespace

Which issue(s) this PR fixes:
Fixes #486 and #460

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@maheshrajamani maheshrajamani self-assigned this Aug 1, 2023
@maheshrajamani maheshrajamani requested a review from a team as a code owner August 1, 2023 14:25
@maheshrajamani maheshrajamani changed the title Find command validation Find command options validation and tenant based cache Aug 1, 2023
tatu-at-datastax
tatu-at-datastax approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think an integration test would be useful for maximum limit.

@maheshrajamani maheshrajamani merged commit 7234562 into main Aug 1, 2023
@maheshrajamani maheshrajamani deleted the find-command-validation branch August 1, 2023 18:37
@maheshrajamani maheshrajamani restored the find-command-validation branch August 1, 2023 18:39
vkarpov15
vkarpov15 reviewed Aug 12, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 left review comments

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

Assignees

@maheshrajamani maheshrajamani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vector search schema cache by tenant
3 participants
@maheshrajamani @vkarpov15 @tatu-at-datastax