-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker compose configuration #49
Conversation
@@ -87,7 +87,7 @@ The available profiles are: | |||
The required profile can be activated using the `-P` option: | |||
|
|||
```shell script | |||
../mvnw integration-test -P cassandra-311 | |||
./mvnw integration-test -P cassandra-311 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to default to 4.0 as 3.11 is being deprecated in near future?
(and users tend to copy-paste examples)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This api will work only against dse or cndb since it needs SAI index. Think we need to default it to dse-6.8 for this api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I won't. That's not really within the scope of this PR.
We should have a separate issue to cleanup the README in terms of how it speaks about what backends the service can be run against.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. But @maheshrajamani is right, we shouldn't include options that do not work. Can def be done in a follow-up
@jeffreyscarpenter On using the script as below, it's trying to get docsapi running. Do this script only bring coordinator up? ./start_dse_68_dev_mode.sh |
As mentioned in the readme you have to build the docker image |
Didn't realize this image is called docsapi. |
Yes, that hasn't been changed yet. |
Will require some modifications when we rename the API, but should be a good starting point for the moment.