Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker compose configuration #49

Merged
merged 5 commits into from
Jan 26, 2023
Merged

Conversation

jeffreyscarpenter
Copy link
Contributor

Will require some modifications when we rename the API, but should be a good starting point for the moment.

@@ -87,7 +87,7 @@ The available profiles are:
The required profile can be activated using the `-P` option:

```shell script
../mvnw integration-test -P cassandra-311
./mvnw integration-test -P cassandra-311
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax Jan 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to default to 4.0 as 3.11 is being deprecated in near future?
(and users tend to copy-paste examples)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This api will work only against dse or cndb since it needs SAI index. Think we need to default it to dse-6.8 for this api.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I won't. That's not really within the scope of this PR.

We should have a separate issue to cleanup the README in terms of how it speaks about what backends the service can be run against.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. But @maheshrajamani is right, we shouldn't include options that do not work. Can def be done in a follow-up

@maheshrajamani
Copy link
Contributor

@jeffreyscarpenter On using the script as below, it's trying to get docsapi running. Do this script only bring coordinator up?

./start_dse_68_dev_mode.sh
Running with DSE 6.8.28, Stargate v2.0.6, JSON API
[+] Running 0/1
⠿ jsonapi Error 0.8s
Error response from daemon: manifest for stargateio/docsapi:v3.0.0-SNAPSHOT not found: manifest unknown: manifest unknown

@jeffreyscarpenter
Copy link
Contributor Author

@jeffreyscarpenter On using the script as below, it's trying to get docsapi running. Do this script only bring coordinator up?

./start_dse_68_dev_mode.sh

Running with DSE 6.8.28, Stargate v2.0.6, JSON API

[+] Running 0/1

⠿ jsonapi Error 0.8s

Error response from daemon: manifest for stargateio/docsapi:v3.0.0-SNAPSHOT not found: manifest unknown: manifest unknown

As mentioned in the readme you have to build the docker image

@maheshrajamani
Copy link
Contributor

Didn't realize this image is called docsapi.

@jeffreyscarpenter
Copy link
Contributor Author

Didn't realize this image is called docsapi.

Yes, that hasn't been changed yet.

@jeffreyscarpenter jeffreyscarpenter merged commit c73d496 into main Jan 26, 2023
@jeffreyscarpenter jeffreyscarpenter deleted the jeff/docker-compose branch January 26, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants