add nb test cases for vector search jsonapi #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| This workflow is perfect for testing Stargate performance using your own JSON dataset or any other realistic dataset. | ||
|
|
||
| In contrast to other workflows, this one is not split into ramp-up and main phases. | ||
| Instead, there is only the main phase with 4 different load types (write, read, update and delete). |
There was a problem hiding this comment.
Is there specific reason why no ramp-up is defined?
| - `dataset_file` - the file to read the JSON documents from (note that if number of documents in a file is smaller than the `docscount` parameter, the documents will be reused) | ||
| - `connections` - number of HTTP2 connections to be shared between the threads (default: `20`) | ||
|
|
||
| note that too many docscount requires larger storage for cassandra backend |
There was a problem hiding this comment.
What does "too many" here mean? Could perhaps be reworded to indicate that if a large number is used, Cassandra backend resources need to be adjusted accordingly (to allow storing all specific documents).
There was a problem hiding this comment.
Thanks, will change with proper statement.
There was a problem hiding this comment.
LGTM but I think someone with more experience (@kathirsvn or @maheshrajamani ) should probably give actual approval.
maheshrajamani
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adding new benchmark file for vector search through jsonapi
Checklist