fix NPE when concurrent delete #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1683,6 +1679,114 @@ public void findOneAndReplace() { | |||
| } | |||
| } | |||
|
|
|||
| @Nested | |||
| @Order(8) | |||
| @TestMethodOrder(MethodOrderer.OrderAnnotation.class) | |||
There was a problem hiding this comment.
These seem to be duplicate for FindOneAndDeleteIntegrationTest, but just with vector column.
I think I would not add these since it's more code to maintain and does not add much more verification.
| @@ -321,4 +317,151 @@ public void checkMetrics() { | |||
| FindOneAndDeleteIntegrationTest.super.checkMetrics("FindOneAndDeleteCommand"); | |||
| } | |||
| } | |||
|
|
|||
| @Nested | |||
| class ConcurrentDelete { | |||
There was a problem hiding this comment.
Good! If these failed (at least for some runs) without the fix, and pass (reliably) with the fix (couple of sample runs should be enough to prove), that's good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
findOneAndDelete with projection under concurrent situation.
For example, some requests read
asuccessfully, but delete will fail becauseahas been deleted. In the retry process, JSON API will try to readaagain, this time it read anull. Then when apply projection, there will be a NPE.This issue will occur not with vectors, but also when doing findOneAndDelete with normal filter +projection.
The fix has passed the IT and also benchmark test.
Which issue(s) this PR fixes:
Fixes #517
Checklist