In support #535
Merged
In support #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current test fail is because of that querybuilder quarkus-common change has not been released. |
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
Outdated
Show resolved
Hide resolved
vkarpov15
reviewed
Sep 24, 2023
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/FindOperation.java
Outdated
Show resolved
Hide resolved
| } | ||
| }); | ||
|
|
||
| return queries; | ||
| if (hasInFilterBesidesIdField.get()) { |
There was a problem hiding this comment.
Number of conditionality is going up. Can you resolve to some type (If possible in the FilterableResolver) and write them with switch case instead of if-else block?
There was a problem hiding this comment.
sorry, Mahesh, after looking into it for a long time.
I do not think this is doable right now, since resolve() method returns List, I need to iterate through the list. I can move some codes forward into FindOneAndDeleteCommandResolver, but does not make a big difference.
Do you have some suggestions.
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
Outdated
Show resolved
Hide resolved
vkarpov15
reviewed
Sep 26, 2023
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/FindOperation.java
Outdated
Show resolved
Hide resolved
maheshrajamani
approved these changes
Sep 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: add in operation for jsonapi
Which issue(s) this PR fixes:
Issue 291
PR 348
Checklist