Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorize update validation #542

Merged
merged 16 commits into from
Sep 26, 2023
Merged

Vectorize update validation #542

merged 16 commits into from
Sep 26, 2023

Conversation

maheshrajamani
Copy link
Contributor

@maheshrajamani maheshrajamani commented Sep 26, 2023 •
edited
Loading

What this PR does:
Following validation of update has been done.

  1. Error if both $vector and $vectorize used in the update clause
  2. If update clause has only $vector field and saved document has $vectorize field too, remove the $vectorize field from the document.

Which issue(s) this PR fixes:
Fixes #533 and #532

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@maheshrajamani
Changes to merge array_equals and sub_doc_equals field into query_tex…
de7eba4 
…t_value fields
@maheshrajamani
Merge branch 'main' of https://github.com/stargate/jsonapi
2950936
@maheshrajamani
Merge branch 'main' of https://github.com/stargate/jsonapi
4f55f16
@maheshrajamani
Added vector search examples to swagger
4687953
@maheshrajamani
Merge branch 'main' of https://github.com/stargate/jsonapi
74725c4
@maheshrajamani
Merge branch 'main' of https://github.com/stargate/jsonapi
4c0b597
@maheshrajamani
Merge branch 'main' of https://github.com/stargate/jsonapi
3a14a04
@maheshrajamani
Merge branch 'main' of https://github.com/stargate/jsonapi
2008d00
@maheshrajamani
Merge branch 'main' of https://github.com/stargate/jsonapi
1c7da70
@maheshrajamani
Merge branch 'main' of https://github.com/stargate/jsonapi
d575a49
@maheshrajamani
Merge branch 'main' of https://github.com/stargate/jsonapi
5e1dbff
@maheshrajamani
Merge remote-tracking branch 'origin/main' into vectorize-update-vali…
1755d02 
…dation
@maheshrajamani
Changes for vectorize update validation
98b183f
@maheshrajamani
Handling of scenario where update done directly to $vector field but …
60bd4f8 
…saved document has $vectorize.
@maheshrajamani maheshrajamani requested a review from a team as a code owner September 26, 2023 15:11
@maheshrajamani maheshrajamani self-assigned this Sep 26, 2023
tatu-at-datastax
tatu-at-datastax approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: added minor suggestions.

@maheshrajamani maheshrajamani merged commit 7401189 into main Sep 26, 2023
3 checks passed
@maheshrajamani maheshrajamani deleted the vectorize-update-validation branch September 26, 2023 21:02
vkarpov15
vkarpov15 reviewed Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

@vkarpov15 vkarpov15 vkarpov15 left review comments

Assignees

@maheshrajamani maheshrajamani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Vectorize] Add validation for update clause
3 participants
@maheshrajamani @vkarpov15 @tatu-at-datastax