Vertex AI embedding client fix #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… find collections operation 2) Find Collections with explain changes.
…napi into describe-collection
src/main/java/io/stargate/sgv2/jsonapi/service/embedding/operation/VertexAIEmbeddingClient.java
Show resolved
Hide resolved
| this.metadata = metadata; | ||
| } | ||
|
|
||
| private static class Prediction { |
There was a problem hiding this comment.
Probably better to keep package protected (no modifier) if and when this needs to be serialized; Jackson can access private classes too, but has to force access and there's (I think) minor performance penalty (not enough to be measurable probably tho).
tatu-at-datastax
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixed the response data parsing for vertex AI.
Not added any test case because it needs API keys.
Tested manually.
Checklist