Fix #572: add ITs to verify empty JSON Object is valid for sort of find/findOne, fix as necessary
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for `sort` for `find()`/`findOne()`
tatu-at-datastax
force-pushed
the
tatu/572-allow-empty-object-for-sort
branch
from
61a28c7 to
1f8d473
Compare
tatu-at-datastax
changed the title
sort of find/findOnesort of find/findOne, fix as necessary
Yuqi-Du
approved these changes
Oct 23, 2023
| @@ -25,18 +25,15 @@ public record SortClause(@Valid List<SortExpression> sortExpressions) { | |||
|
|
|||
| public boolean hasVsearchClause() { | |||
| return sortExpressions != null | |||
| && sortExpressions.stream() | |||
There was a problem hiding this comment.
Problem was that not only is null check needed, but also isEmpty() for specific case of explicitly empty sort.
But we also don't need to create stream() etc as it's a List can just get the first (and only, for vector/vectorize case as no combinations allowed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds 2 ITs for find()/findOne()
Which issue(s) this PR fixes:
Fixes #572
Checklist