provide additional detail on swagger docs for insertMany #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I could tell, this was the only place in swagger docs that references the "specification" so hopefully we will not have other issues like this. |
tatu-at-datastax
approved these changes
Oct 25, 2023
|
Really good improvement, let's do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing some users have become confused by the behavior of the
insertManycommand with respect to how partial failure is handled. Users don't realize that setting theorderedoption to false will allow them to bypass the default fail fast behavior, which returns on the first insert failure, even a failure as simple as inserting a duplicate_id.Instead of referencing "specifications" that most users will not know how to find, this PR updates the swagger docs to pull in the detail from the spec.
Checklist