Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native image building with datastax driver dependency #598

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

kathirsvn
Copy link
Contributor

What this PR does:

-Dquarkus.native.additional-build-args='--initialize-at-run-time=com.datastax.oss.driver.internal.core.metadata.MetadataManager'

Which issue(s) this PR fixes:
Fixes #597

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@kathirsvn kathirsvn requested a review from a team as a code owner October 27, 2023 12:26
@Yuqi-Du
Copy link
Contributor

Yuqi-Du commented Oct 27, 2023

I am thinking could we move this -Dquarkus.native.additional-build-args to configuration.yaml?
Since if every time we find some classes which need a runtime initialization, we add the command, the command will be longer?

Not very sure.

@kathirsvn
Copy link
Contributor Author

Good point @Yuqi-Du. Also, less change :-) Updated in this commit de2a049.

Copy link
Contributor

@Yuqi-Du Yuqi-Du left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you for adding a reference to issue, important to know where this setting came from (and why)

@kathirsvn kathirsvn merged commit f8ed7a3 into main Oct 31, 2023
3 checks passed
@kathirsvn kathirsvn deleted the native_image_fix branch October 31, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native Image build failure
3 participants