Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support empty or null options for commands #60

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Support empty or null options for commands #60

merged 2 commits into from
Feb 1, 2023

Conversation

maheshrajamani
Copy link
Contributor

Added placeholder options record in all the commands, Will add different applicable options as its added

tatu-at-datastax
tatu-at-datastax approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one note on @JsonProperty probably being unnecessary, but looks good otherwise.

@maheshrajamani maheshrajamani merged commit 8f6c017 into main Feb 1, 2023
@maheshrajamani maheshrajamani deleted the add-empty-options branch February 1, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maheshrajamani @tatu-at-datastax