token header name "X-Casssandra-Token" -> "Token" #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/io/stargate/sgv2/jsonapi/api/security/ErrorChallengeSender.java
Show resolved
Hide resolved
tatu-at-datastax
approved these changes
Nov 2, 2023
vkarpov15
reviewed
Nov 3, 2023
| String AUTHENTICATION_TOKEN_HEADER_NAME = "Token"; | ||
|
|
||
| /** JSON API also supports X-Cassandra-Token for backward compatibility. */ | ||
| String DEPRECATED_AUTHENTICATION_TOKEN_HEADER_NAME = "X-Cassandra-Token"; |
There was a problem hiding this comment.
Do we have a test that tests the deprecated header still works? It looks like all the tests just use the AUTHENTICATION_TOKEN_HEADER_NAME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
change token header name, "X-Casssandra-Token" -> "Token"
also supports X-Cassandra-Token for backward compatibility
Which issue(s) this PR fixes:
Fixes #569
Checklist