fix collection not exist #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/io/stargate/sgv2/jsonapi/service/bridge/executor/NamespaceCache.java
Show resolved
Hide resolved
tatu-at-datastax
approved these changes
Nov 2, 2023
vkarpov15
reviewed
Nov 3, 2023
| // collection does not exist | ||
| if (error instanceof RuntimeException rte | ||
| && rte.getMessage() | ||
| .startsWith(ErrorCode.INVALID_COLLECTION_NAME.getMessage())) { |
There was a problem hiding this comment.
Not wrong, but in my experience it is usually best practice to check against the error code or some other constant other than the error message, because (1) error messages may change, (2) it is possible that there may be multiple types of errors that start with the same message. Not a blocker, just figured I'd point this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when collection does not exist, operation involves vsearch will not error out as "collection not exist", but "vector search not enabled on this collection" which is misleading.
Which issue(s) this PR fixes:
Fixes #609
Checklist