_id field to support String, Number, Boolean and Null Json type #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/JsonType.java
Show resolved
Hide resolved
src/main/java/io/stargate/sgv3/docsapi/service/shredding/model/DocumentId.java
Outdated
Show resolved
Hide resolved
| @@ -61,8 +61,10 @@ public static Map<QueryOuterClass.Value, QueryOuterClass.Value> getDoubleMapValu | |||
| return to; | |||
| } | |||
|
|
|||
| public static QueryOuterClass.Value getDocumentIdValue(DocumentId documentId) { | |||
| public static List<QueryOuterClass.Value> getDocumentIdValue(DocumentId documentId) { | |||
There was a problem hiding this comment.
Is this because Tuples are expressed as Lists in protobuf/bridge/grpc?
src/main/java/io/stargate/sgv3/docsapi/service/operation/model/impl/DeleteOperation.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv3/docsapi/service/shredding/model/DocumentId.java
Show resolved
Hide resolved
src/main/java/io/stargate/sgv3/docsapi/service/shredding/model/DocumentId.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv3/docsapi/service/shredding/model/DocumentId.java
Outdated
Show resolved
Hide resolved
tatu-at-datastax
requested changes
Feb 1, 2023
There was a problem hiding this comment.
I think this makes sense: at first I was confused by new JsonType but I think I got it.
Couple of changes that I think are needed:
toString()is not allowed to returnnullAFAIK (forNullId)- Need to add constants for numeric type ids (probably in
DocumentId), refer to those - Can eliminate one part of
BiMap: dynamical lookup only needed going from databasetinyintintoJsonType; but the other direction (DocumentIdsubtypes'value()) can just directly return constant
src/main/java/io/stargate/sgv3/docsapi/service/shredding/model/DocumentId.java
Outdated
Show resolved
Hide resolved
…csapi into key-type-change
src/main/java/io/stargate/sgv3/docsapi/service/shredding/model/DocumentId.java
Show resolved
Hide resolved
| @@ -163,6 +207,73 @@ public void insertDocument() { | |||
| .body("data.docs[0]", jsonEquals(expected)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void insertDocumentWithDifferentTypes() { | |||
tatu-at-datastax
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for DB storage and filter logic for id fields Issue #58