Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert "FindOperationTest" to not use ValidatingBridge #677

Merged
merged 19 commits into from
Nov 28, 2023
Merged

Convert "FindOperationTest" to not use ValidatingBridge #677

merged 19 commits into from
Nov 28, 2023

Conversation

tatu-at-datastax
Copy link
Contributor

What this PR does:

Change "FindOperationTest" to not use ValidatingBridge but instead mock QueryExecutor directly.

Which issue(s) this PR fixes:
N/A

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax self-assigned this Nov 22, 2023
maheshrajamani
maheshrajamani approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@maheshrajamani maheshrajamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Are you doing a PR for stargate to remove the assert to get other test case to succeed?

src/main/java/io/stargate/sgv2/jsonapi/service/shredding/model/DocValueHasher.java Outdated Show resolved Hide resolved
@tatu-at-datastax tatu-at-datastax marked this pull request as ready for review November 28, 2023 16:18
@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner November 28, 2023 16:18
@tatu-at-datastax tatu-at-datastax merged commit 72cde4f into main Nov 28, 2023
3 checks passed
@tatu-at-datastax tatu-at-datastax deleted the tatu/v2-3003-convert-insert-oper-test branch November 28, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maheshrajamani maheshrajamani maheshrajamani approved these changes

Assignees

@tatu-at-datastax tatu-at-datastax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tatu-at-datastax @maheshrajamani