Convert InsertOperationTest to use native CQL not validating Bridge
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatu-at-datastax
changed the title
InsertOperationTest to use native CQL not validating BridgeInsertOperationTest to use native CQL not validating Bridge
src/main/java/io/stargate/sgv2/jsonapi/service/cqldriver/serializer/CQLBindValues.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/cqldriver/serializer/CQLBindValues.java
Show resolved
Hide resolved
maheshrajamani
approved these changes
Nov 30, 2023
src/test/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/InsertOperationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/cqldriver/serializer/CQLBindValues.java
Outdated
Show resolved
Hide resolved
| @@ -31,10 +32,10 @@ public static Set<String> getSetValue(Set<JsonPath> from) { | |||
| } | |||
|
|
|||
| public static Set<String> getStringSetValue(Set<String> from) { | |||
| return from.stream().map(val -> val.toString()).collect(Collectors.toSet()); | |||
| return new LinkedHashSet<>(from); | |||
There was a problem hiding this comment.
No point calling String.toString() or using stream operation; if we want a copy create directly.
But caller probably shouldn't need to call this method at all TBH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Converts "InsertOperationTest" to work with new CQL-based access
Which issue(s) this PR fixes:
Fixes C2-3098
Checklist