Fix #686: add ITs to verify Max-String-Value-Length constaints #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not having much success: updated |
…s Astra) from 1kB (default)
…er for reproduction)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds Integration tests checking handling of both too-long-String-values and as-long-as-possible-String values (already have unit tests)
NOTE: limit of 8kB defined with overrides will become default for Astra too, although current limit is 5KB. But this change is safe since we formerly allowed 16,000 character Strings so we are getting closer to accurate limits for JSON API.
Which issue(s) this PR fixes:
Fixes #686
Checklist