Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In nin array subdoc #737

Merged
merged 21 commits into from
Dec 19, 2023
Merged

In nin array subdoc #737

merged 21 commits into from
Dec 19, 2023

Conversation

Yuqi-Du
Copy link
Contributor

@Yuqi-Du Yuqi-Du commented Dec 14, 2023 •
edited
Loading

What this PR does:
support $in and $nin for array and sub_doc

{
  "find": {
   "filter" : {"array_field": {"$in" : [["A", "B", "C"], ["X", "Y", "Z"]] } }
  }
}
{
  "find": {
   "filter" : {"sub_doc_field": {"$in" : [ { "A" : "B" }] } }
  }
}

Which issue(s) this PR fixes:
Fixes 732

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

Yuqi-Du added 20 commits December 5, 2023 12:01
@Yuqi-Du
$exists support false
097491c 
(need v2.1 release)
@Yuqi-Du
add $exists false tests,
4a0ed4c 
IT will fail, since IT relies on cassandra backend with no support for not operator
@Yuqi-Du
$ne for non_id field
b74a615
@Yuqi-Du
$nin for non_id field
61d2b87
@Yuqi-Du
$nin for _id field
4403ace 
(many corners cases)
@Yuqi-Du
fix operationsConfig.maxInOperatorValueSize()
23bcd5b
@Yuqi-Du
Merge remote-tracking branch 'origin/main' into changes_with_cassandr…
4843f69 
…a_not_operator

# Conflicts:
#	src/main/java/io/stargate/sgv2/jsonapi/api/model/command/clause/filter/ValueComparisonOperator.java
#	src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
@Yuqi-Du
format, merged from main
f303217
@Yuqi-Du
unit tests
3a78091
@Yuqi-Du
Merge remote-tracking branch 'origin/main' into changes_with_cassandr…
ff537ab 
…a_not_operator
@Yuqi-Du
abandon usage of allow filtering
aef1db0
@Yuqi-Du
resolve comment
3bd6265
@Yuqi-Du
resolve comment
c1be974 
add tests
@Yuqi-Du
Merge remote-tracking branch 'origin/main' into changes_with_cassandr…
306a57e 
…a_not_operator
@Yuqi-Du
Merge remote-tracking branch 'origin/main' into changes_with_cassandr…
3fefa25 
…a_not_operator
@Yuqi-Du
remove allow filtering wrapper
fda7442
@Yuqi-Du
Merge remote-tracking branch 'origin/main' into changes_with_cassandr…
3c4007e 
…a_not_operator
@Yuqi-Du
add more tests
e105137
@Yuqi-Du
supprt $nin, $in for array and sub_doc
9183bb5
@Yuqi-Du
Merge remote-tracking branch 'origin/main' into in_nin_array_subdoc
92c75c5 
# Conflicts:
#	src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
#	src/test/java/io/stargate/sgv2/jsonapi/api/v1/InAndNinIntegrationTest.java
@Yuqi-Du Yuqi-Du requested a review from a team as a code owner December 14, 2023 20:57
vkarpov15
vkarpov15 approved these changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but LGTM overall

src/test/java/io/stargate/sgv2/jsonapi/api/v1/InAndNinIntegrationTest.java Outdated Show resolved Hide resolved
Hazel-Datastax
Hazel-Datastax approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@Hazel-Datastax Hazel-Datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yuqi-Du Yuqi-Du merged commit ce3f677 into main Dec 19, 2023
3 checks passed
@Yuqi-Du Yuqi-Du deleted the in_nin_array_subdoc branch December 19, 2023 00:22
vkarpov15
vkarpov15 reviewed Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatu-at-datastax tatu-at-datastax tatu-at-datastax left review comments

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@Hazel-Datastax Hazel-Datastax Hazel-Datastax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$in and $nin, support for array and subdoc
4 participants
@Yuqi-Du @vkarpov15 @tatu-at-datastax @Hazel-Datastax