[Indexing options] Changes for find collections to return indexing option #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,8 @@ public record CreateCollectionCommand( | |||
| public record Options( | |||
|
|
|||
| // limit of returned documents | |||
| @Schema( | |||
| @JsonInclude(JsonInclude.Include.NON_NULL) | |||
There was a problem hiding this comment.
We could also use JsonInclude.Include.NON_EMPTY which would exclude empty Collections.
There was a problem hiding this comment.
Ah., got it I will change it.
...ain/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/FindCollectionsOperation.java
Outdated
Show resolved
Hide resolved
tatu-at-datastax
approved these changes
Jan 10, 2024
…e/jsonapi into indexing-find-collection
Yuqi-Du
reviewed
Jan 10, 2024
| .body("status.collections", hasSize(4)) | ||
| .body( | ||
| "status.collections", | ||
| containsInAnyOrder( |
There was a problem hiding this comment.
I thought we only expect 'expected4' here.
No need for expected1, expected2, expected3.
There was a problem hiding this comment.
find collection returns all the collection created thus far. So add all 4.
vkarpov15
reviewed
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Changes for find collections to return indexing option
Which issue(s) this PR fixes:
Fixes #769
Checklist